[Glass] Simple questions while migrating code to GemStone (compatibility issues)

Johan Brichau johan at yesplan.be
Wed Nov 20 11:18:50 PST 2013 

Hi Mariano,

Fork and pull request is the way to go.

thx
Johan

On 20 Nov 2013, at 19:50, Mariano Martinez Peck <marianopeck at gmail.com> wrote:

> HI guys,
> 
> I was planing to commit by Gs-Pharo-Core but I wonder...should I clone and commit directly, or fork and pull request? 
> yes, git newbie here ;)
> 
> Just in case, we are talking about:
> 
> https://github.com/glassdb/PharoCompatibility
> 
> Cheers,
> 
> 
> On Sun, Nov 17, 2013 at 3:18 PM, Dale K. Henrichs <dale.henrichs at gemtalksystems.com> wrote:
> Johan,
> 
> I've moved the GsParo-Core packages into this repo, added a license (please add yourselves and/or correct as you see fit), and hooked up travis.
> 
> When running the tests there are some test errors and failures[1]. So either those are open issues or something else is up ... I will go ahead and push my changes into the glassdb repo and turn on travis there as well ...
> 
> Dale
> 
> [1] https://travis-ci.org/dalehenrich/PharoCompatibility/jobs/14104855#L126
> 
> ----- Original Message -----
> | From: "Dale K. Henrichs" <dale.henrichs at gemtalksystems.com>
> | To: "Johan Brichau" <johan at yesplan.be>
> | Cc: glass at lists.gemtalksystems.com, "Mariano Martinez Peck" <marianopeck at gmail.com>
> | Sent: Sunday, November 17, 2013 8:36:30 AM
> | Subject: Re: [Glass] Simple questions while migrating code to GemStone (compatibility issues)
> |
> | Great!
> |
> | I'll spend some time and hook things up to travis and add a MIT
> | license file ... which you will want to edit as a contributor ...
> |
> | Dale
> |
> | ----- Original Message -----
> | | From: "Johan Brichau" <johan at yesplan.be>
> | | To: "Dale K. Henrichs" <dale.henrichs at gemtalksystems.com>
> | | Cc: glass at lists.gemtalksystems.com, "Mariano Martinez Peck"
> | | <marianopeck at gmail.com>
> | | Sent: Sunday, November 17, 2013 2:16:38 AM
> | | Subject: Re: [Glass] Simple questions while migrating code to
> | | GemStone (compatibility issues)
> | |
> | | Mariano, Dale,
> | |
> | | I set up a new repository and copied in our port of the
> | | multilingual
> | | textconversion package (aka text encoding conversion) of Pharo.
> | |
> | | https://github.com/glassdb/PharoCompatibility
> | |
> | | For this repo and send pull requests to merge things in.
> | | I did the same and will add code via our fork.
> | |
> | | Off to the races! ;-)
> | | Johan
> | |
> | | On 16 Nov 2013, at 19:46, Dale K. Henrichs
> | | <dale.henrichs at gemtalksystems.com> wrote:
> | |
> | | > Excellent!
> | | >
> | | > ----- Original Message -----
> | | > | From: "Johan Brichau" <johan at yesplan.be>
> | | > | To: "Mariano Martinez Peck" <marianopeck at gmail.com>
> | | > | Cc: "Dale K. Henrichs" <dale.henrichs at gemtalksystems.com>,
> | | > | glass at lists.gemtalksystems.com
> | | > | Sent: Saturday, November 16, 2013 1:46:55 AM
> | | > | Subject: Re: [Glass] Simple questions while migrating code to
> | | > | GemStone (compatibility issues)
> | | > |
> | | > | Ok guys,
> | | > |
> | | > | In that case, I think I will create a new repository in glassdb
> | | > | and
> | | > | just commit all the code we have over there.
> | | > | The reason is that I will want to fork that repository myself
> | | > | and
> | | > | contribute like that.
> | | > | Perhaps I'm old-fashioned but I prefer the <master> repository
> | | > | to
> | | > | be
> | | > | the glassdb one.
> | | > |
> | | > | I'm taking care of it right away!
> | | > |
> | | > | Johan
> | | > |
> | | > | On 16 Nov 2013, at 00:08, Mariano Martinez Peck
> | | > | <marianopeck at gmail.com> wrote:
> | | > |
> | | > | > Hi guys,
> | | > | >
> | | > | > For me it is the same. I am new here, so I let you choose.
> | | > | > Just
> | | > | > let
> | | > | > me know what do I clone, where do I commit and I start :)
> | | > | >
> | | > | > Thanks!
> | | > | >
> | | > | >
> | | > | > On Fri, Nov 15, 2013 at 7:52 PM, Dale K. Henrichs
> | | > | > <dale.henrichs at gemtalksystems.com> wrote:
> | | > | > Johan,
> | | > | >
> | | > | > I am heading in the direction of putting all of the GLASS
> | | > | > (GsWebEdition?, Garnet?, Geode?, Onyx?, Agate?) related
> | | > | > repositories on github, so that would be my preference for
> | | > | > moving
> | | > | > forward...
> | | > | >
> | | > | > The sharing part is the most important and I think Gitub/git
> | | > | > is
> | | > | > the
> | | > | > most powerfull combo for collaboration...
> | | > | >
> | | > | > I can fork you library on glassdb and that way you won't be
> | | > | > the
> | | > | > bottleneck for pull requests and then Mariano can fork the
> | | > | > glassdb
> | | > | > repo and we can be off to the races ...
> | | > | >
> | | > | > Dale
> | | > | >
> | | > | > ----- Original Message -----
> | | > | > | From: "Johan Brichau" <johan at yesplan.be>
> | | > | > | To: "Dale K. Henrichs" <dale.henrichs at gemtalksystems.com>
> | | > | > | Cc: "Mariano Martinez Peck" <marianopeck at gmail.com>,
> | | > | > | glass at lists.gemtalksystems.com
> | | > | > | Sent: Friday, November 15, 2013 10:59:47 AM
> | | > | > | Subject: Re: [Glass] Simple questions while migrating code
> | | > | > | to
> | | > | > | GemStone (compatibility issues)
> | | > | > |
> | | > | > | Dale, Mariano,
> | | > | > |
> | | > | > | Indeed we need to sync :-)
> | | > | > |
> | | > | > | Especially because I now realise that I have not been
> | | > | > | consistent.
> | | > | > | I
> | | > | > | added the packages Gettext and OrderPreservingDictionary to
> | | > | > | the
> | | > | > | Pharocompat repository [1] as Dale suggested a couple of
> | | > | > | years
> | | > | > | back
> | | > | > | (but most of the other packages I never touched -- they are
> | | > | > | included
> | | > | > | in GLASS).
> | | > | > |
> | | > | > | The reason I started the PharoCompatibility repository [2]
> | | > | > | on
> | | > | > | github
> | | > | > | was actually more motivated by the fact that github is more
> | | > | > | convenient for working together on a single code base
> | | > | > | (using
> | | > | > | pull
> | | > | > | requests, travis etc.) and the fact that I wanted a good
> | | > | > | place to
> | | > | > | host code to improve on the 'develop in Pharo, deploy in
> | | > | > | Gemstone'
> | | > | > | experience. I was not sure if that would need to be in
> | | > | > | GLASS
> | | > | > | directly.
> | | > | > |
> | | > | > | I'm more in favour of using a github repository (a new one
> | | > | > | would
> | | > | > | be
> | | > | > | fine too) but I guess it depends if we want the code to be
> | | > | > | in
> | | > | > | GLASS
> | | > | > | immediately or as an add-on. The latter would be feasible
> | | > | > | but
> | | > | > | I'm
> | | > | > | guessing Dale is not quite ready to include github-hosted
> | | > | > | repositories in the GLASS codebase.
> | | > | > |
> | | > | > | What are your opinions?
> | | > | > |
> | | > | > | [1] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | | > | > | [2] https://github.com/jbrichau/PharoCompatibility
> | | > | > |
> | | > | > | On 15 Nov 2013, at 17:53, Dale K. Henrichs
> | | > | > | <dale.henrichs at gemtalksystems.com> wrote:
> | | > | > |
> | | > | > | > Before we go to far down any one path, let's coordinate
> | | > | > | > with
> | | > | > | > Johan,
> | | > | > | > because he has additional pharo methods that he would
> | | > | > | > like
> | | > | > | > to
> | | > | > | > share and I assume he started with the packages in
> | | > | > | > PharoCompat
> | | > | > | > so
> | | > | > | > I would prefer to minimze the proliferation of packages
> | | > | > | > to
> | | > | > | > merge
> | | > | > | > ...
> | | > | > | >
> | | > | > | > If Johan thinks that putting your changes into
> | | > | > | > PharoCompat
> | | > | > | > makes
> | | > | > | > sense, then go ahead and do so ...
> | | > | > | >
> | | > | > | > In the mean time, I will add you to the glass developers
> | | > | > | > team,
> | | > | > | > which should give you write access to all of the relevant
> | | > | > | > repos
> | | > | > | > on
> | | > | > | > GemSource ...
> | | > | > | >
> | | > | > | > Have you registered on GemSource? I didn't find you
> | | > | > | > there...
> | | > | > | >
> | | > | > | > Dale
> | | > | > | >
> | | > | > | > From: "Mariano Martinez Peck" <marianopeck at gmail.com>
> | | > | > | > To: "Dale K. Henrichs" <dale.henrichs at gemtalksystems.com>
> | | > | > | > Cc: glass at lists.gemtalksystems.com
> | | > | > | > Sent: Friday, November 15, 2013 6:45:09 AM
> | | > | > | > Subject: Re: [Glass] Simple questions while migrating
> | | > | > | > code
> | | > | > | > to
> | | > | > | > GemStone (compatibility issues)
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | > - I really miss the #split: and #join: methods. Maybe
> | | > | > | > these
> | | > | > | > could
> | | > | > | > be ported to GemStone? Or are there similar methods
> | | > | > | > already?
> | | > | > | >
> | | > | > | > I'm not familiar with split:/join: but would be in favor
> | | > | > | > of
> | | > | > | > having
> | | > | > | > them added to the compat layer. It looks like  #split:
> | | > | > | > has
> | | > | > | > been
> | | > | > | > added to the pharo compat layer in the GsPharo-Core
> | | > | > | > package
> | | > | > | > on
> | | > | > | > GemSource[3] ... I think that I should move the GsPharo*
> | | > | > | > packages
> | | > | > | > onto the github repository to make it easy to contribute
> | | > | > | > ...
> | | > | > | >
> | | > | > | > The GsSqueakCommon* packages are for methods and classes
> | | > | > | > that
> | | > | > | > have
> | | > | > | > identical implementations on both Squeak and Pharo. there
> | | > | > | > are
> | | > | > | > GsPharo-* and GsSqueak-* packages for methods and classes
> | | > | > | > that
> | | > | > | > are
> | | > | > | > unique to each platform ...
> | | > | > | >
> | | > | > | > If you are interested in adding #join: support, I'll move
> | | > | > | > the
> | | > | > | > GsPharo-* packages to the github repo ...
> | | > | > | >
> | | > | > | > Dale
> | | > | > | >
> | | > | > | > [3] http://seaside.gemtalksystems.com/ss/PharoCompat.html
> | | > | > | >
> | | > | > | >
> | | > | > | > Dale, I have ported the rest of the tests and protocols
> | | > | > | > of
> | | > | > | > #join:
> | | > | > | > and #split: . All tests but one are green. I wanted to
> | | > | > | > commit
> | | > | > | > to
> | | > | > | > such a repo but I don't have access. Could you please add
> | | > | > | > me?
> | | > | > | >
> | | > | > | > Thanks,
> | | > | > | >
> | | > | > | >
> | | > | > | >
> | | > | > | > --
> | | > | > | > Mariano
> | | > | > | > http://marianopeck.wordpress.com
> | | > | > | >
> | | > | > | > _______________________________________________
> | | > | > | > Glass mailing list
> | | > | > | > Glass at lists.gemtalksystems.com
> | | > | > | > http://lists.gemtalksystems.com/mailman/listinfo/glass
> | | > | > |
> | | > | > |
> | | > | >
> | | > | >
> | | > | >
> | | > | > --
> | | > | > Mariano
> | | > | > http://marianopeck.wordpress.com
> | | > |
> | | > |
> | |
> | |
> |
> 
> 
> 
> -- 
> Mariano
> http://marianopeck.wordpress.com

More information about the Glass mailing list