[Glass] Locked by Smalltalkhub and Tonel

[bruno buzzi brassesco]

Dale,

Now all Tests are green for GS 3.1.0.6, 3.2.17, 3.3.9, 3.4.5, 3.5.0, 3.5.4.
Check at:
https://travis-ci.org/github/brunobuzzi/OrderPreservingDictionary/builds/737198238

Do you want me to add another GS version ?

Tomorrow I will send the PR so now we have 2 of 5.

regards,
bruno

On 16/10/2020 21:07, Dale Henrichs via Glass wrote:
>
>
> On 10/16/20 4:59 PM, bruno buzzi brassesco via Glass wrote:
>>
>> Dale,
>>
>> I will help no problem :)
>> Maybe i was not clear enough.
>>
>> The tests all green in GS versions: 3.2.17, 3.3.9, 3.4.5, 3.5.0 and 
>> 3.5.4.
>> In GS 3.1.0.6 almost all tests pass but #testCopy .
>>
> Ah, much clearer...
>>
>> After debugging i found that :
>> |d1 d2 |
>> d1 := OrderPreservingIdentityStringDictionary new.
>> d1 at: '1' put: '1'.
>> d2 := d1 copy.
>> (d1 associations at: 1) == (d2 associations at: 1)
>>
>> GS 3.1.0.6 answer true. In others versions answer false.
>> Any way on Monday afternoon i will research further.
>>
> It does appear that one of the #copy methods is doing a deeper copy in 
> 3.1.0.6 which IS interesting ... have a good weekend!
>
> Dale
>
>
> _______________________________________________
> Glass mailing list
> Glass at lists.gemtalksystems.com
> https://lists.gemtalksystems.com/mailman/listinfo/glass
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gemtalksystems.com/mailman/private/glass/attachments/20201019/936852d2/attachment.htm>