[Glass] adding profiling to GemStone

[Dale K. Henrichs]

Otto,

I created a pull request[1] that fixes the problems that I ran into with this code.

I "fixed the problem with the profiled block not returning" by putting in an ensure block ... AFAIK, when one is working with #handleFiltered:, the code that follows the block does not get executed because continuations are getting created and normal block execution does not apply ... I looked at the other filter tools and it looks like they were all using ensure blocks to perform work "after block execution" and that grick worked for WAProfilerItem>>profile too.

Once I got past that I ran into an issue with  WAHttpVersion>>= and its interaction with WAGemStoneInspector...

I haven't done anything more with the profile, but it is tempting to port the Seaside2.8 code to Seaside3.0, since I'm in the neighborhood:)

Dale

[1] https://github.com/finworks/Seaside30/pull/1
[2] https://github.com/finworks/Seaside30/pull/1/files#diff-c0eef7b0cdc9950e3b3d984ae86197eaL2

----- Original Message -----
| From: "Dale K. Henrichs" <dale.henrichs at gemtalksystems.com>
| To: "Otto Behrens" <otto at finworks.biz>
| Cc: glass at lists.gemtalksystems.com, "Seaside - general discussion" <seaside at lists.squeakfoundation.org>
| Sent: Sunday, January 5, 2014 10:08:24 AM
| Subject: Re: [Glass] adding profiling to GemStone
| 
| 
| 
| ----- Original Message -----
| | From: "Otto Behrens" <otto at finworks.biz>
| | To: glass at lists.gemtalksystems.com, "Seaside - general discussion"
| | <seaside at lists.squeakfoundation.org>
| | Sent: Tuesday, December 31, 2013 6:03:17 AM
| | Subject: [Glass] adding profiling to GemStone
| | 
| 
| ....
| 
| | The GemStone version is simplistic at the moment; I'm really
| | battling
| | to get it to work in GemStone. My problem is that the block being
| | profiled does not return; the response notification seem to block
| | in
| | GemStone and does not return in #handleFiltered:. I would like to
| | incorporate ProfMonitor, but I'm not even getting as far as
| | measuring
| | the time it took to execute #handleFiltered:.
| 
| Otto,
| 
| Just to get onto the same page, when I load Seaside from the
| portProfilerToolToGemStone branch, I get a MNU in my browser (see
| attach png)...
| 
| I'm working in 3.x (3.2 actually ... using tODE), so if you are
| seeing something different, then I will need to switch to 2.4.4...
| 
| Dale