[Glass] RefactoringBrowser (RB) failing to correctly bind "self" in closures?

Dale Henrichs via Glass glass at lists.gemtalksystems.com
Mon Nov 23 12:47:39 PST 2015


BTW, if any other GsDevKit_home user wants to pick up the RB bugfixes do 
the following:

   updateGsDevKit -st

update shared repos and tODE repos ... do not update clients as RB is 
only used on the server.

Then for each of the tODE stones you are using (and want updated):

   todeUpdate <stone-name>

Dale

On 11/23/2015 12:36 PM, Dale Henrichs wrote:
> Tests were green, so I merged your pull request ... thanks!
>
> Dale
>
> On 11/23/2015 11:47 AM, Mariano Martinez Peck wrote:
>> OK Dale,
>>
>> Can you check if everything went correct with my PR?
>>
>> Thanks
>>
>> On Mon, Nov 23, 2015 at 3:15 PM, Dale Henrichs 
>> <dale.henrichs at gemtalksystems.com 
>> <mailto:dale.henrichs at gemtalksystems.com>> wrote:
>>
>>
>>
>>     On 11/23/2015 05:12 AM, Mariano Martinez Peck wrote:
>>>
>>>
>>>     On Sun, Nov 22, 2015 at 4:17 PM, Dale Henrichs
>>>     <dale.henrichs at gemtalksystems.com> wrote:
>>>
>>>         Cool ....
>>>
>>>         Now, tODE only loads AST-Core and I just checked and there
>>>         _was_ only one test error (a test problem that I just
>>>         fixed), so you must be using other parts of RB ....
>>>
>>>         Perhaps we could do a mini sprint for RB and get the tests
>>>         passing for more of the system?
>>>
>>>         If you are interested perhaps you could let me know what
>>>         sub-systems you are using and we could divvy up the tests?
>>>
>>>
>>>     I am supposed to be using the AST-Core package. However, it
>>>     seems that even in Pharo, there is no test that covers my scenario.
>>     haha, well this cuts down the scope of the RB sprint ... the
>>     100's of faiing tests were in the other parts of RB that aren't
>>     loaded with AST-Core....
>>>
>>>     Before I fork and commit the fix, let me ask...shouldn't we move
>>>     RB from dalehenrichs into gsDevKitHome?   even more because it's
>>>     even used by tODE right?  I guess you will need to update a
>>>     couple of things of gsDevKit_home scripts in order to get the
>>>     new repo, but probably worth.
>>>     Anyway, let me know what do you think.
>>>
>>     I would say that you can go ahead and fork my repo ... when It is
>>     moved to GsDevKit, ownership will be re-assigned so the repo will
>>     move and your fork will point to the GsDevKit version ... to keep
>>     old things working, I will make a new fork of rb ....
>>
>>     replacing the cloned repo will be a bit dicier but can be done
>>     with a little work .. something that I don't necessarily want to
>>     have to deal with at the moment:)
>>
>>     Dale
>>
>>
>>
>>
>> -- 
>> Mariano
>> http://marianopeck.wordpress.com
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gemtalksystems.com/mailman/private/glass/attachments/20151123/59ba7759/attachment-0001.html>


More information about the Glass mailing list