[Glass] Locked by Smalltalkhub and Tonel

[Dale Henrichs]

On 10/16/20 5:11 AM, bruno buzzi brassesco via Glass wrote:
>
> Dale,
>
> OrderPreservingDictionary 
> (https://github.com/brunobuzzi/OrderPreservingDictionary) is working 
> with GS:  3.5.4, 3.5.0, 3.4.5, 3.3.9, 3.2.17
> But fail with: GS 3.1.0.6 -Array does not understand #'identityIncludes:-
>
I think it makes sense to add Array>>identityIncludes: to a new 
Collections-OrderPreservingDictionary-GemStone31x package that is 
conditional on gs3.1.x.
>
> https://travis-ci.org/github/brunobuzzi/OrderPreservingDictionary
>
> I only added one method to AbstractDictionary :)
>
> Now i have a couple of questions:
> * There are 3 ston files (smalltalk, pharo and gemstone), these files 
> has to be done in all repos ? (i should add them to my 
> OrderPreservingDictionary ?)
>
It's up to you, I think, I split the gemstone and pharo ston files for 
the other projects because gemstone had not been added in the first 
place, so I decided to preserve the pharo versions and then create the 
gemstone variants so that only gemstone would be tested and we wouldn't 
have to worry about any changes that might be needed to keep the pharo 
versions running ....

At this point in time, I'm thinking that we'll keep these projects alive 
until tonel format is officially supported by GLASS and GemStone 
(sometime next year with the release of 3.7) when GLASS is reading 
tonel, we should then merge these projects back into the 
pharo-contributions project ... so we can handle the ston files any way 
we want ...

> * The same with yml files (i should add them to my 
> OrderPreservingDictionary ?)
>
> I think after solving the questions above i can send you a PR and take 
> on the next project.
>
sounds good .. thanks a lot for your effort!

Dale

> regards,
> bruno
>
> On 15/10/2020 16:24, bruno buzzi brassesco via Glass wrote:
>>
>> Dale,
>>
>> Excellent.
>> I just forked all repos and now i will start to look at them.
>>
>> regards,
>> bruno
>>
>> On 15/10/2020 15:59, Dale Henrichs via Glass wrote:
>>>
>>> Haha, looks like BitmapCharacterSet project is passing travis 
>>> tests[1] for GemStone! One down and 4 to go...
>>>
>>> Dale
>>>
>>> [1] 
>>> https://travis-ci.org/github/GsDevKit/BitmapCharacterSet/jobs/736139167
>>>
>>> On 10/15/20 11:56 AM, Dale Henrichs wrote:
>>>>
>>>> I also created and install script and put usage instructions in the 
>>>> readme for https://github.com/GsDevKit/T2F2T-Conversion, now that 
>>>> you no longer need to use it :) ...
>>>>
>>>> I made my pass over the new XML projects and found one spot that 
>>>> needed updating. You probably want to `git pull origin gemstone` on 
>>>> all of the projects lease feel free to ask me any questions moving 
>>>> forwar
>>>>
>>>> On 10/15/20 11:38 AM, Dale Henrichs wrote:
>>>>>
>>>>> ... and I created a gemstone branch (default)
>>>>>
>>>>> Dale
>>>>>
>>>>> On 10/15/20 11:35 AM, Dale Henrichs wrote:
>>>>>>
>>>>>> I just finished converting 
>>>>>> https://github.com/pharo-contributions/BitmapCharacterSet to 
>>>>>> https://github.com/GsDevKit/BitmapCharacterSet with the tonel 
>>>>>> directory copied and converted to filetree ...
>>>>>>
>>>>>> Each of these converted projects:
>>>>>>
>>>>>>     https://github.com/GsDevKit/BitmapCharacterSet
>>>>>>     https://github.com/GsDevKit/OrderPreservingDictionary
>>>>>>     https://github.com/GsDevKit/XML-XMLWriter
>>>>>>     https://github.com/GsDevKit/XML-XMLParser
>>>>>>     https://github.com/GsDevKit/XML-XPath
>>>>>>
>>>>>> has been forked from the corresponding 
>>>>>> https://github.com/pharo-contribution project. Each of those 
>>>>>> projects has a `src` directory that is in tonel format. My 
>>>>>> conversion process involves converting the tonel packages in the 
>>>>>> `src` directory into filetree packages in the `filetree` directory.
>>>>>>
>>>>>> I have also converted the .travis artifacts to point to the 
>>>>>> gemstone filetree directories (I'll double check:) and converted 
>>>>>> the baselines to reference the GsDevKit projects and updated the 
>>>>>> travis bug in the readme
>>>>>>
>>>>>> On 10/15/20 10:24 AM, bruno buzzi brassesco via Glass wrote:
>>>>>>>
>>>>>>> Dale,
>>>>>>>
>>>>>>> It seems i misunderstood your previous mail.
>>>>>>> If you can convert all needed package from Tonel to FileTree and 
>>>>>>> i can load them on a clean GS image --> i can take a look at 
>>>>>>> failing tests and fix some error and create PRs.
>>>>>>>
>>>>>>> regards,
>>>>>>> bruno
>>>>>>>
>>>>>>> On 15/10/2020 13:57, Dale Henrichs via Glass wrote:
>>>>>>>>
>>>>>>>> Bruno,
>>>>>>>>
>>>>>>>> I have been converting the pharo-contributions/XML* projects 
>>>>>>>> from GITHUB, not SmalltalkHub ... I guess I thought that you 
>>>>>>>> said you wanted those projects converted from tonel to filetree 
>>>>>>>> ... perhaps it doesn't matter, since I don't think a lot was 
>>>>>>>> done in the pharo-contributions  projects other than convert to 
>>>>>>>> tonel and remove the gemstone baseline entries:)
>>>>>>>>
>>>>>>>> Presumably you have an image with 
>>>>>>>> http://smalltalkhub.com/PharoExtras/OrderPreservingDictionary/Collections-OrderPreservingDictionaryGemstoneCompatibility-monty.1.mcz 
>>>>>>>> in it and you should be able to save that mcz file into the 
>>>>>>>> OrderPreservingDictionary filetree repository ...
>>>>>>>>
>>>>>>>> I plan to convert 
>>>>>>>> https://github.com/pharo-contributions/BitmapCharacterSet (not 
>>>>>>>> from smalltalkhub), but I won't do the work until later today, 
>>>>>>>> so if you need me to go a different direction let me know...
>>>>>>>>
>>>>>>>> Dale
>>>>>>>>
>>>>>>>> On 10/15/20 9:40 AM, bruno buzzi brassesco via Glass wrote:
>>>>>>>>>>
>>>>>>>>>> Bruno,
>>>>>>>>>>
>>>>>>>>>> OrderPreesrvingDictionary is forked and converted to filetree 
>>>>>>>>>> ... the filetree directory in each of the repos is the repo 
>>>>>>>>>> of record for GemStone ...
>>>>>>>>>>
>>>>>>>>>> It looks like the travis build is failing because the 
>>>>>>>>>> Collections-OrderPreservingDictionary-GemstoneCompatibility 
>>>>>>>>>> package was removed from the project ... that will probably 
>>>>>>>>>> have to be recovered from smalltalkHub as a first order of 
>>>>>>>>>> business ...
>>>>>>>>>>
>>>>>>>>> This is:
>>>>>>>>> http://smalltalkhub.com/PharoExtras/OrderPreservingDictionary/Collections-OrderPreservingDictionaryGemstoneCompatibility-monty.1.mcz
>>>>>>>>> or
>>>>>>>>> http://smalltalkhub.com/PharoExtras/OrderPreservingDictionary/Collections-OrderPreservingDictionary-GemstoneCompatibility-monty.1.mcz
>>>>>>>>>
>>>>>>>>> My project use the first but i do not know which is the most 
>>>>>>>>> recent.
>>>>>>>>>
>>>>>>>>>> I update the XMLParser and XMLWriter projects to reference 
>>>>>>>>>> the GsDevKit/OrderPreservingDictionary ... XML-XPath is 
>>>>>>>>>> failing because of an issue with BitmapCharacterSet project 
>>>>>>>>>> another tonel package problem ... let me know if that one 
>>>>>>>>>> needs to converted as well ..
>>>>>>>>>>
>>>>>>>>> This is:
>>>>>>>>> http://smalltalkhub.com/PharoExtras/BitmapCharacterSet/Collections-BitmapCharacterSet-monty.25.mcz
>>>>>>>>>
>>>>>>>>> I think converting those to FileTree and we are done :)
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> bruno
>>>>>>>>>
>>>>>>>>>> Dale
>>>>>>>>>>
>>>>>>>>>> [1] https://github.com/GsDevKit/OrderPreservingDictionary
>>>>>>>>>> [2] 
>>>>>>>>>> https://travis-ci.org/github/GsDevKit/OrderPreservingDictionary/jobs/735565502#L2036
>>>>>>>>>>
>>>>>>>>>> On 10/13/20 1:03 PM, Dale Henrichs wrote:
>>>>>>>>>>>
>>>>>>>>>>> Yes, but I don't think there a good instructions for 
>>>>>>>>>>> installing Rowan:) and the other details and it is easier 
>>>>>>>>>>> for me to just do the clone myself:) ... which I will do 
>>>>>>>>>>> later this afternoon ...
>>>>>>>>>>>
>>>>>>>>>>> Dale
>>>>>>>>>>>
>>>>>>>>>>> On 10/13/20 12:26 PM, bruno buzzi brassesco wrote:
>>>>>>>>>>>>> They are all failing (at the moment) because  of problems 
>>>>>>>>>>>>> loading the OrderPreservingDictionary project[1], which is 
>>>>>>>>>>>>> not surprising, because it is a tonel-based project. If 
>>>>>>>>>>>>> you need that project forked and converted to Filetree, 
>>>>>>>>>>>>> let me know. At this point it takes just a few minutes to 
>>>>>>>>>>>>> convert from tonel to filetree using the T2F2T-Conversion 
>>>>>>>>>>>>> project[2].
>>>>>>>>>>>>
>>>>>>>>>>>> Dale,
>>>>>>>>>>>>
>>>>>>>>>>>> In order to do this myself I have to install Rowan in my 
>>>>>>>>>>>> GemStone/S repo ?
>>>>>>>>>>>>
>>>>>>>>>>>> Or just cloning/forking 
>>>>>>>>>>>> https://github.com/GsDevKit/T2F2T-Conversion and run the 
>>>>>>>>>>>> script is enough ?
>>>>>>>>>>>>
>>>>>>>>>>>> regards,
>>>>>>>>>>>> bruno
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Glass mailing list
>>>>>>>>> Glass at lists.gemtalksystems.com
>>>>>>>>> https://lists.gemtalksystems.com/mailman/listinfo/glass
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Glass mailing list
>>>>>>>> Glass at lists.gemtalksystems.com
>>>>>>>> https://lists.gemtalksystems.com/mailman/listinfo/glass
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Glass mailing list
>>>>>>> Glass at lists.gemtalksystems.com
>>>>>>> https://lists.gemtalksystems.com/mailman/listinfo/glass
>>>
>>> _______________________________________________
>>> Glass mailing list
>>> Glass at lists.gemtalksystems.com
>>> https://lists.gemtalksystems.com/mailman/listinfo/glass
>>
>> _______________________________________________
>> Glass mailing list
>> Glass at lists.gemtalksystems.com
>> https://lists.gemtalksystems.com/mailman/listinfo/glass
>
> _______________________________________________
> Glass mailing list
> Glass at lists.gemtalksystems.com
> https://lists.gemtalksystems.com/mailman/listinfo/glass
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gemtalksystems.com/mailman/private/glass/attachments/20201016/78ac9f7c/attachment-0001.htm>